svn commit: r462637 - head/devel/py-py

[Bryan Drewery]

On 2/22/2018 11:51 AM, Sunpoet Po-Chuan Hsieh wrote:
> Author: sunpoet
> Date: Thu Feb 22 19:51:25 2018
> New Revision: 462637
> URL: https://svnweb.freebsd.org/changeset/ports/462637
> 
> Log:
>   Remove TEST_DEPENDS to avoid circular dependency
>   
>   PR:		220284
>   Reported by:	danfe
> 
> Modified:
>   head/devel/py-py/Makefile
> 
> Modified: head/devel/py-py/Makefile
> ==============================================================================
> --- head/devel/py-py/Makefile	Thu Feb 22 19:51:20 2018	(r462636)
> +++ head/devel/py-py/Makefile	Thu Feb 22 19:51:25 2018	(r462637)
> @@ -13,8 +13,6 @@ COMMENT=	Library with cross-python path, ini-parsing, 
>  LICENSE=	MIT
>  LICENSE_FILE=	${WRKSRC}/LICENSE
>  
> -TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${FLAVOR}
> -
>  NO_ARCH=	yes
>  USES=		python
>  USE_PYTHON=	autoplist distutils
> 

This change is wrong and should be reverted, see
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220284#c6

It's like trying to run a BUILD_DEPENDS before it is built and installed
which is independent of RUN_DEPENDS; You cannot run a TEST_DEPENDS
before it is built and installed, which is independent of RUN_DEPENDS.

The bug here is Tinderbox.  We should not be removing valid dependencies
just to appease a broken tool (especially one barely used).  Sure
Tinderbox "used to" work here, but that's exactly why it should not be
used - it is not properly maintained to keep up with framework updates
like TEST_DEPENDS.

Poudriere has not yet implemented 'make test' because this problem is
hard. The naive 'make test' call after 'make stage' is just wrong.  One
possible solution is to do multiple passes. Build everything, then test
everything. Independent "builds".  It gets more complicated because
"make test" expected to have the port staged, so in my solution you
would have to keep a copy of the stagedir for the port until the testing
pass and then extract it, install TEST_DEPENDS, and run the tests.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180222/f6f86c62/attachment.sig>