svn commit: r488719 - in head: sysutils/kf5-kwallet www/falkon x11/plasma5-plasma

[Tobias Kortkamp]

On Sun, Dec 30, 2018 at 02:15:54PM +0000, Adriaan de Groot wrote:
> Author: adridg
> Date: Sun Dec 30 14:15:54 2018
> New Revision: 488719
> URL: https://svnweb.freebsd.org/changeset/ports/488719
> 
> Log:
>   Add OPTIONS to some kde@ ports.
>   
>   For best runtime performance (e.g. a fully functional desktop), users will
>   need a pinentry application -- pinentry-qt fits best into the KDE desktop,
>   but it could be a different one -- and sound output. Pick a default backend
>   and some OSS plugins to make that happen.
>   
>   These are OPTIONS so the users interested in a minimal desktop or one with
>   different audio needs can build suitable packages themselves.
>   
>   Reviewed by:	tcberner
>   Differential Revision:	https://reviews.freebsd.org/D18680
> 
> Modified:
>   head/sysutils/kf5-kwallet/Makefile
>   head/www/falkon/Makefile
>   head/x11/plasma5-plasma/Makefile
> 
> Modified: head/www/falkon/Makefile
> ==============================================================================
> --- head/www/falkon/Makefile	Sun Dec 30 14:05:27 2018	(r488718)
> +++ head/www/falkon/Makefile	Sun Dec 30 14:15:54 2018	(r488719)
> @@ -2,7 +2,7 @@
>  
>  PORTNAME=	falkon
>  DISTVERSION=	3.0.0
> -PORTREVISION=	2
> +PORTREVISION=	3
>  CATEGORIES=	www
>  MASTER_SITES=	KDE/stable/falkon/${DISTVERSION:R}/src/
>  
> @@ -21,11 +21,16 @@ USE_XORG=	xcb
>  
>  USE_LDCONFIG=	yes
>  
> -OPTIONS_DEFINE=	GNOMEKEYRING
> +OPTIONS_DEFINE=	GNOMEKEYRING ALSA
> +OPTIONS_DEFAULT=	ALSA
>  OPTIONS_SUB=	YES
>  
>  GNOMEKEYRING_CMAKE_BOOL=	BUILD_KEYRING
>  GNOMEKEYRING_USE=		GNOME=glib20
>  GNOMEKEYRING_LIB_DEPENDS=	libgnome-keyring.so:security/libgnome-keyring
> +
> +# Need the plugins to get sound, otherwise messages that the
> +# pcm_oss plugin can't be opened.
> +ALSA_RUN_DEPENDS=	alsa-plugins>=0:audio/alsa-plugins

This seems really backwards to me.  Would it not make more sense
to add the ALSA plugins bit to qt5-webengine?  It is after all
qt5-webengine that outputs sound not Falkon itself.  What about all
the other browsers based on qt5-webengine (otter-browser, konqueror,
qutebrowser, ...)?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181230/a5650b71/attachment.sig>