svn commit: r488248 - in head/net-im: . pidgin-icyque

[Mathieu Arnold]

On Mon, Dec 24, 2018 at 12:35:31AM +0000, Eugene Grosbein wrote:
> +BUILD_DEPENDS=	pidgin:net-im/pidgin
> +RUN_DEPENDS=	pidgin:net-im/pidgin
> +LIB_DEPENDS=	libjson-glib-1.0.so:devel/json-glib \
> +		libpurple.so:net-im/libpurple

The order is BUILD/LIB/RUN.

> +PLIST_FILES=	lib/purple-2/libicyque.so

Wrong place in the Makefile.  See https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

> +WRKSRC=		${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}

Not needed.

> +USE_GNOME=	glib20
> +USE_LDCONFIG=	yes

Wrong place in the Makefile (though removing the WRKSRC above will fix
it.)

> +This is a Libpurple plugin for ICQ/WIM protocol.

This is way too short, pkg-descr must be at least a couple of lines
long.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181224/1b15dc17/attachment.sig>