svn commit: r487866 - head/sysutils/xorriso

[Mathieu Arnold]

On Fri, Dec 21, 2018 at 06:16:11PM -1000, Gerald Pfeifer wrote:
> On Thu, 20 Dec 2018, Tobias Kortkamp wrote:
> >> Author: yuri
> >> Date: Thu Dec 20 08:52:35 2018
> >> New Revision: 487866
> > This isn't right.  A new file is installed, so a PORTREVISION bump
> > is required.  It should be added as INFO (or TK_INFO since it appears
> > to be optional similar to xorriso-tcltk.1.gz) to the port if it's
> > really needed so that indexinfo is called after install.
> > 
> > The port already has that and also has do-install-TK-off which
> > deletes it from STAGEDIR but the info path was not adjusted in
> > r484628 when ${PREFIX}/info was moved to ${PREFIX}/share/info.
> 
> I see that Yuri applied a follow-up patch based on your feedback,
> but would do you think about the following?
> 
> From Mk/bsd.ports.mk:
> 
>   # INFO_PATH     - Path, where all .info files will be installed by your
>   #                 port, relative to ${PREFIX}
> 
> And:
> 
>   INFO_PATH?= share/info
> 
> 
> Okay to apply the little patch below?
> 
> Gerald
> 
> Index: sysutils/xorriso/Makefile
> ===================================================================
> --- sysutils/xorriso/Makefile	(revision 488030)
> +++ sysutils/xorriso/Makefile	(working copy)
> @@ -51,7 +51,7 @@
>  do-install-TK-off:
>  	${RM} ${STAGEDIR}${PREFIX}/bin/xorriso-tcltk \
>  		${STAGEDIR}${PREFIX}/man/man1/xorriso-tcltk.1.gz \
> -		${STAGEDIR}${PREFIX}/share/info/xorriso-tcltk.info
> +		${STAGEDIR}${PREFIX}/${INFO_PATH}/xorriso-tcltk.info

Only if the patch actually respects INFO_PATH and it does not breka if the path changes.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181222/d00aee3a/attachment.sig>