svn commit: r487403 - head/databases/puppetdb-cli

[Romain Tartière]

On Fri, Dec 14, 2018 at 06:19:50AM +0100, Jan Beich wrote:
> Romain Tartière <romain at FreeBSD.org> writes:
> 
> > +BROKEN_SSL_REASON_libressl=	Needs an old version of OpenSSL (older than 1.1)
> 
> Does it build fine with DEFAULT_VERSIONS+=libressl-devel ?

Of course not, good catch!  Probably the same for openssl-devel but it
seems absent as of today, so I don't know if we should add it.

> > +.include <bsd.port.pre.mk>
> 
> .include <bsd.port.options.mk> would have been enough.

Yes, it seems to be okay too.  I was following
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#dads-after-port-mk

> > +.if ${OSVERSION} >= 1200085
> 
> Checking OSVERSION without OPSYS is illegal. DragonFly has OSVERSION=9999999
> with LibreSSL 2.4.4 in base.
> 
> https://github.com/DragonFlyBSD/DPorts/blob/f18014a15a13/Mk/bsd.port.mk#L1184
> https://github.com/DragonFlyBSD/DragonFlyBSD/blob/bd84e83893b2/crypto/libressl/README.DRAGONFLY

Fixed!

> > +BROKEN_SSL+=	base
> 
> BROKEN_SSL=base is *not supported* by USES=ssl, and BROKEN_SSL cannot set
> after bsd.port.pre.mk because USES=ssl was already processed by that time.

D'oh!  Maybe this information may have it's place in the Porter's Handbook:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#uses-ssl

I tried to workaround this by testing OPSYS && OSVERSION && SSL_DEFAULT
and setting BROKEN if all conditions are met.  Quite ugly, but should
get the work done.  If you see a better way to fix this, please tell me.

Thanks!


-- 
Romain Tartière <romain at FreeBSD.org>  http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181213/db02f995/attachment.sig>