svn commit: r449798 - head/net-mgmt/collectd5

Steve Wills swills at FreeBSD.org
Thu Sep 14 22:12:30 UTC 2017


Hi,

I'm happy to see more options enabled by default in this port, thanks 
for that. We do have a policy that packaged binaries should be stripped. 
Enabling the DEBUG option by default would seem to be at odds with that 
policy to me. Could you please turn that one off by default?

Thanks,
Steve

On 09/13/2017 10:55, Dag-Erling Smørgrav wrote:
> Author: des
> Date: Wed Sep 13 14:55:45 2017
> New Revision: 449798
> URL: https://svnweb.freebsd.org/changeset/ports/449798
> 
> Log:
>    Enable the DEBUG, GCRYPT and PING options by default.
>    
>    DEBUG is required for any sort of troubleshooting, GCRYPT is required to
>    encrypt communication with the server, and PING is one of the most basic
>    sensors which everybody uses.  My hope is that with these three options,
>    more people will be able to use collectd without having to recompile it.
>    
>    Approved by:	maintainer
> 
> Modified:
>    head/net-mgmt/collectd5/Makefile
> 
> Modified: head/net-mgmt/collectd5/Makefile
> ==============================================================================
> --- head/net-mgmt/collectd5/Makefile	Wed Sep 13 14:45:29 2017	(r449797)
> +++ head/net-mgmt/collectd5/Makefile	Wed Sep 13 14:55:45 2017	(r449798)
> @@ -3,6 +3,7 @@
>   
>   PORTNAME=	collectd
>   PORTVERSION=	5.7.2
> +PORTREVISION=	1
>   CATEGORIES=	net-mgmt
>   MASTER_SITES=	https://collectd.org/files/ \
>   		http://collectd.org/files/
> @@ -26,6 +27,8 @@ OPTIONS_GROUP_INPUT=	CHRONY CURL CURL_JSON CURL_XML DB
>   			PERL PGSQL PINBA PING PYTHON RABBITMQ REDIS ROUTEROS \
>   			SIGROK SNMP STATSD TOKYOTYRANT VARNISH XML \
>   			XMMS ZOOKEEPER
> +
> +OPTIONS_DEFAULT=	DEBUG GCRYPT PING
>   
>   CGI_DESC=		Install collection.cgi (requires rrdtool)
>   CHRONY_DESC=		Enable chronyd plugin
> 


More information about the svn-ports-all mailing list