svn commit: r449703 - in head/graphics: xpdf xpdf4

[Cy Schubert]

In message <57f600ab-e484-7174-2789-ca010f402f12 at FreeBSD.org>, Mathieu 
Arnold w
rites:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --mSWnV2Lnucm3ikSatJiaari9puPnXDUVR
> Content-Type: multipart/mixed; boundary="pWV58FPDs983JJ91XbPcSNuJOFjtOdTUQ";
>  protected-headers="v1"
> From: Mathieu Arnold <mat at FreeBSD.org>
> To: Cy Schubert <cy at FreeBSD.org>, ports-committers at freebsd.org,
>  svn-ports-all at freebsd.org, svn-ports-head at freebsd.org
> Message-ID: <57f600ab-e484-7174-2789-ca010f402f12 at FreeBSD.org>
> Subject: Re: svn commit: r449703 - in head/graphics: xpdf xpdf4
> References: <201709121904.v8CJ4Ylv074168 at repo.freebsd.org>
> In-Reply-To: <201709121904.v8CJ4Ylv074168 at repo.freebsd.org>
> 
> --pWV58FPDs983JJ91XbPcSNuJOFjtOdTUQ
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: quoted-printable
> Content-Language: fr
> 
> Le 12/09/2017 =C3=A0 21:04, Cy Schubert a =C3=A9crit=C2=A0:
> > -	${LN} -sf ${PREFIX}/libexec/xpdf/xpdf ${STAGEDIR}${PREFIX}/bin/xpdf
> > +	@cd ${STAGEDIR}${PREFIX}; \
> > +	${LN} -sf libexec/xpdf/xpdf bin/xpdf
> > =20
> >
> > -		${LN} -sf ${PREFIX}/libexec/xpdf/xpdf ${STAGEDIR}${PREFIX}/bin/
> xpdf
> > +		@cd ${STAGEDIR}${PREFIX}; \
> > +		${LN} -sf libexec/xpdf/xpdf bin/xpdf
> > +
> 
> Good example of when not to use ${LN} because you will get it wrong.
> (Hint, the new version you committed is wrong, the previous was bad but
> working.)
> 
> Please read:
> https://www.freebsd.org/doc/en/books/porters-handbook/special.html#stagin=
> g-symlink

That was my fault. The original ${LN} was to work around conflicts between 
the original xpdf and poppler (which is a prereq for a number of other 
ports). I'll look at cleaning this up, which may need some patching of 
Makefiles provided in the tarballs.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.