svn commit: r449357 - in head/net-p2p/mktorrent: . files

[Alexey Dokuchaev]

On Thu, Sep 07, 2017 at 02:04:34PM +0200, Christian Weisgerber wrote:
> Alexey Dokuchaev:
> > > ...
> > > -MASTER_SITES=	SF
> > > +MASTER_SITES=	https://github.com/Rudde/mktorrent/archive/
> > > +DISTNAME=	v${PORTVERSION}
> > > +DIST_SUBDIR=	${PORTNAME}
> > 
> > Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these
> > DIST_SUBDIR dances?
> 
> I don't know which scheme is preferable.  The Porter's Handbook
> section on USE_GITHUB starts with "If the distribution file comes
> from a specific commit or tag on GitHub for which there is no
> officially released file, [...]".  But here we have an officially
> released if awkwardly named distfile.

It was fixed by mat@ (I guess he got tired of trying to teach people and
just silently cleans up after them now).

I suggest you follow other people commits in addition to reading the PHB,
it'll give you ideas and examples of the most common/current practices.

./danfe