svn commit: r449195 - head/security/py-cryptography

[Sunpoet Po-Chuan Hsieh]

On Mon, Sep 4, 2017 at 11:29 AM, Kubilay Kocak <koobs at freebsd.org> wrote:

> On 9/3/17 8:28 PM, Rene Ladan wrote:
> > Author: rene
> > Date: Sun Sep  3 10:28:00 2017
> > New Revision: 449195
> > URL: https://svnweb.freebsd.org/changeset/ports/449195
> >
> > Log:
> >   security/py-cryptography: remove support for expired Python 3.3
> >
> > Modified:
> >   head/security/py-cryptography/Makefile
> >
> > Modified: head/security/py-cryptography/Makefile
> > ============================================================
> ==================
> > --- head/security/py-cryptography/Makefile    Sun Sep  3 10:12:26 2017
>       (r449194)
> > +++ head/security/py-cryptography/Makefile    Sun Sep  3 10:28:00 2017
>       (r449195)
> > @@ -35,8 +35,6 @@ RUN_DEPENDS+=       ${PYTHON_PKGNAMEPREFIX}ipaddr
> ess>0:net/p
> >
> >  .if ${PYTHON_REL} < 3300
> >  RUN_DEPENDS+=        ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34
> > -.elif ${PYTHON_REL} < 3400
> > -RUN_DEPENDS+=        ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum34
> >  .endif
> >
> >  post-install:
> >
>
>
Hi,


> Please revert this change:
>
> - It is *meant* to include all versions below 3.4, including 2.7
>

I also got confused when I see it at the first time.
Note the ".elif" which means ${PYTHON_REL} >= 3300 and ${PYTHON_REL} < 3400.
It only includes python 3.3.


> - It is not necessary to delete when a python language port version is
> removed. The block still semantically and correctly declares the valid
> version dependency requirements from the upstream, independently from
> what the tree has at any point in time.
>

In this case, it should be removed.
devel/py3-enum34 depends on expired python 3.3 only.


>
> Also, if you could, please ask/talk to python maintainers and/or python@
> with regard to port deprecation/deletions before committing. It is not
> always entirely obvious or explicit what is the correct thing to do is
> without fully understanding the versions support and semantics completely.
>

I appreciate René's help for cleaning up expired ports.
IMHO, if we want to extend the support period, it would be better to change
EXPIRATION_DATE before its expiration.

Regards,
sunpoet


> _______________________________________________
> freebsd-python at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-python
> To unsubscribe, send any mail to "freebsd-python-unsubscribe at freebsd.org"