svn commit: r452416 - in head/graphics/opensubdiv: . files

[Jan Beich]

Tijl Coosemans <tijl at FreeBSD.org> writes:

> On Thu, 19 Oct 2017 19:18:21 +0200 Jan Beich <jbeich at FreeBSD.org> wrote:
>
>> Steve Wills <swills at FreeBSD.org> writes:
>>> +	${FIND} ${WRKSRC}/regression -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \
>>> +	-e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/test|g'  
>> 
>> According to hier(7) and devel/kyua tests should probably go under
>> tests/${PORTNAME}.
>> 
>> Why use xargs(1) for a feature built into find(1)?
>> 
>>      -exec utility [argument ...] {} +
>>              Same as -exec, except that "{}" is replaced with as many
>>              pathnames as possible for each invocation of utility.  This
>>              behaviour is similar to that of xargs(1).  The primary always
>>              returns true; if at least one invocation of utility returns a
>>              non-zero exit status, find will return a non-zero exit status.
>> 
>
> XARGS is usually faster because find runs the command for every file
> while xargs batches all files in a single command.

Did you mistake "-exec ... {} +" for "-exec ... {} ;" ?