svn commit: r441282 - in head: . security security/acme.sh

[Dan Langille]

> On May 20, 2017, at 5:06 AM, Joseph Mingrone <jrm at FreeBSD.org> wrote:
> 
> Adam Weinberger <adamw at adamw.org> writes:
> 
>>> On 19 May, 2017, at 20:27, Dan Langille <dvl at FreeBSD.org> wrote:
> 
>>> Author: dvl
>>> Date: Sat May 20 02:27:45 2017
>>> New Revision: 441282
>>> URL: https://svnweb.freebsd.org/changeset/ports/441282
> 
>>> Log:
>>> A pure Unix shell script implementing ACME client protocol
> 
>>> Differential Revision: https://reviews.freebsd.org/D10308
> 
>>> Added:
>>> head/security/acme.sh/
>>> head/security/acme.sh/Makefile   (contents, props changed)
>>> head/security/acme.sh/distinfo   (contents, props changed)
>>> head/security/acme.sh/pkg-descr   (contents, props changed)
>>> Modified:
>>> head/GIDs
>>> head/UIDs
>>> head/security/Makefile
> 
> 
>>> +RUN_DEPENDS=	curl:ftp/curl
>>> +
>>> +OPTIONS_DEFINE=	CURL DOCS WGET
>>> +OPTIONS_DEFAULT=	CURL
>>> +CURL_DESC=	Add ftp/curl as a run-time dependency
>>> +WGET_DESC=	Add ftp/wget as a run-time dependency
>>> +
>>> +CURL_RUN_DEPENDS=	curl:ftp/curl
>>> +WGET_RUN_DEPENDS=	wget:ftp/wget
> 
>> Hi Dan,
> 
>> You have curl as a mandatory and optional dependency, which effectively makes curl mandatory. I think you want to use OPTIONS_SINGLE or OPTIONS_MULTI here, to make it an actual choice between the two of them.
> 
>> Also the descriptions are a bit strange. I mean, it does add them as a dependency, but I think an end-user would be more concerned with what curl or wget does for acme.sh, no?
> 
>> # Adam
> 
> Hi Adam, Dan,
> 
> The link below is a patch with proposed changes.
> 
> http://ftfl.ca/misc/acme.sh-2.6.9.diff
> 
> Changelog:
> - Add OPTION_SINGLE for choosing one of cURL or Wget for HTTP(s) queries
> - Update CURL/WGET descriptions [1]
> - Silence porlint warnings
> 
> [1] They do not say "Use cURL/Wget...", because acme.sh will, by
>    default, use cURL if both cURL and Wget are installed


Patch committed.  Thank you.
--
Dan Langille - BSDCan / PGCon
dan at langille.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 625 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170520/9cdc9335/attachment.sig>