svn commit: r441282 - in head: . security security/acme.sh

[Adam Weinberger]

> On 19 May, 2017, at 20:27, Dan Langille <dvl at FreeBSD.org> wrote:
> 
> Author: dvl
> Date: Sat May 20 02:27:45 2017
> New Revision: 441282
> URL: https://svnweb.freebsd.org/changeset/ports/441282
> 
> Log:
>  A pure Unix shell script implementing ACME client protocol
> 
>  Differential Revision: https://reviews.freebsd.org/D10308
> 
> Added:
>  head/security/acme.sh/
>  head/security/acme.sh/Makefile   (contents, props changed)
>  head/security/acme.sh/distinfo   (contents, props changed)
>  head/security/acme.sh/pkg-descr   (contents, props changed)
> Modified:
>  head/GIDs
>  head/UIDs
>  head/security/Makefile
> 
> 
> +RUN_DEPENDS=	curl:ftp/curl
> +
> +OPTIONS_DEFINE=	CURL DOCS WGET
> +OPTIONS_DEFAULT=	CURL
> +CURL_DESC=	Add ftp/curl as a run-time dependency
> +WGET_DESC=	Add ftp/wget as a run-time dependency
> +
> +CURL_RUN_DEPENDS=	curl:ftp/curl
> +WGET_RUN_DEPENDS=	wget:ftp/wget

Hi Dan,

You have curl as a mandatory and optional dependency, which effectively makes curl mandatory. I think you want to use OPTIONS_SINGLE or OPTIONS_MULTI here, to make it an actual choice between the two of them.

Also the descriptions are a bit strange. I mean, it does add them as a dependency, but I think an end-user would be more concerned with what curl or wget does for acme.sh, no?

# Adam


-- 
Adam Weinberger
adamw at adamw.org
https://www.adamw.org