svn commit: r445076 - in head/x11-servers: xorg-nestserver/files xorg-server xorg-server/files xorg-vfbserver/files xwayland/files

[Matthew Rezny]

On Saturday 08 July 2017 14:38:18 Jan Beich wrote:
> Matthew Rezny <rezny at freebsd.org> writes:
> > Since fcntl is used to add FD_CLOEXEC after the unlink, there is zero
> > functional difference between using mkstemp and mkostemp with O_CLOEXEC.
> > Therefore, the the patch is entirely unnecessary cruft.
> 
> Not zero, see existing HAVE_MKOSTEMP check in hw/xwayland/xwayland-shm.c.
> This change was about *atomic* close-on-exec. Anyway, I've sent a better
> version upstream.

That is a point that could have been made clear in a PR. Saying "like Linux" 
in the commit message did not make that intent clear.

Please open a PR with the better version or provide a link to the patch 
proposed upstream.