svn commit: r445123 - in head/net-mgmt/ccnet-client: . files

[Richard Gallamore]

My apologies, will add a more details of changes in the
commit log in the future. The reasoning for the change 
is in the porters handbook, 13.1.7. USES and USE_x. This
section suggests that USES should start the section
block then USE_x should follow. Agreed about USE_GITHUB
being more distfile related and probably should be
considered to be moved to that section block.

A little off topic, in the beginning of the same chapter,
the example Makefile has items out of order and I keep
wondering to myself if this is on purpose.

Anyways will be more detailed in commit log, thanks for
the feedback!

Richard Gallamore


On 07/07/2017 05:01, Alexey Dokuchaev wrote:
> On Thu, Jul 06, 2017 at 02:21:23AM +0000, Richard Gallamore wrote:
>> New Revision: 445123
>> URL: https://svnweb.freebsd.org/changeset/ports/445123
>>
>> Log:
>>   * Add patch to fix build for libressl
>>   * Removed --enable-ldap, not a valid configure arg
>>   
>> [...]
>> @@ -21,19 +22,17 @@ LIB_DEPENDS=	libsearpc.so:devel/libsearpc \
>>  
>>  CONFLICTS=	ccnet-server-[0-9]*
>>  
>> -USE_GITHUB=	yes
>> -GH_ACCOUNT=	haiwen
>> -GH_PROJECT=	ccnet
>> -
>>  USES=		autoreconf gettext libtool localbase pathfix pkgconfig \
>>  		python:-2.7 ssl
>>  USE_GNOME=	glib20
>>  USE_LDCONFIG=	yes
>>  USE_OPENLDAP=	yes
>> +USE_GITHUB=	yes
>> +GH_ACCOUNT=	haiwen
>> +GH_PROJECT=	ccnet
> Please try to avoid these gratuitous changes.  GitHub-related knobs are
> often grouped together and put closer to the top because they are more
> related to obtaining the distfile (think MASTER_SITES) rather than the
> configuring/building/etc. steps of software itself.
>
> In any case, this move should've been reflected in the commit log with
> proper explanation.
>
> ./danfe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170707/4c505ab9/attachment-0001.sig>