svn commit: r448472 - in head: Mk/Uses archivers/freetar archivers/unarchiver archivers/zipper audio/cddb-bundle audio/gnustep-cdplayer audio/mpdcon biology/biococoa databases/fortytwo-bdb database...

[Antoine Brodin]

On Mon, Aug 21, 2017 at 1:42 PM, Antoine Brodin <antoine at freebsd.org> wrote:
> On Mon, Aug 21, 2017 at 1:26 PM, David Chisnall <theraven at freebsd.org> wrote:
>> Author: theraven
>> Date: Mon Aug 21 13:26:28 2017
>> New Revision: 448472
>> URL: https://svnweb.freebsd.org/changeset/ports/448472
>>
>> Log:
>>   Update GNUstep core libraries.
>>
>>   Update the default Objective-C compiler.
>>
>>   Fix various build failures in GNUstep ports from newer versions of the GNUstep
>>   core libraries and from changes to GNUstep Make.
>>
>>   Update various ports that use GNUstep and bump the portrevision of the ones
>>   that haven't had a new release.
> ...
>> Modified: head/Mk/Uses/objc.mk
>> ==============================================================================
>> --- head/Mk/Uses/objc.mk        Mon Aug 21 13:14:02 2017        (r448471)
>> +++ head/Mk/Uses/objc.mk        Mon Aug 21 13:26:28 2017        (r448472)
> ...
>> -# We do always need clang
>> -.if ${COMPILER_TYPE} != clang
>> -.if ${ALT_COMPILER_TYPE} == clang
>> +# We do always need clang and prefer a recent version
>> +.if (${COMPILER_TYPE} == clang && ${COMPILER_VERSION} < ${OBJC_CLANG_VERSION}) || ${COMPILER_TYPE} != clang
>
> Hi,
>
> The condition for the compiler version seems reversed?

I misread the double-if.

Cheers,

Antoine