svn commit: r447657 - in head/devel: . evemu evemu/files

[Mathieu Arnold]

Le 10/08/2017 à 00:04, Vladimir Kondratyev a écrit :
> On 2017-08-10 00:37, Mathieu Arnold wrote:
>> Le 09/08/2017 à 23:00, Vladimir Kondratyev a écrit :
>>> +CATEGORIES=     devel
>>
>> There is a whitespace violation here, it seems there are spaces and not
>> tabs after the =.
>>
>>> +USES=        tar:xz python:2,build pathfix libtool pkgconfig localbase
>>> +
>>> +PYTHON_RUN_DEPENDS=        ${PYTHON_CMD}:${PYTHON_PORTSDIR}
>>
>> This is a bit awful, it should probably better be:
>> PYTHON_USES=    python:2
>> PYTHON_USES_OFF=    python:2,build
>
> Hi, Mathieu
>
> I had build-tested above-mentioned changes with poudriere and got 'no
> pkg-list issues' with PYTHON option in both ON and OFF states
>
> Do you approve attached patch?


Well, the attached patch seems fine, you will need your mentors approval
for it, though :-)


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170810/343befdb/attachment.sig>