svn commit: r422826 - head/security/libsodium

[John Marino]

On 9/27/2016 16:14, Mathieu Arnold wrote:
> Le 27/09/2016 à 21:51, John Marino a écrit :
>> On 9/27/2016 14:43, Vsevolod Stakhov wrote:
>>> Author: vsevolod
>>> Date: Tue Sep 27 19:43:32 2016
>>> New Revision: 422826
>>> URL: https://svnweb.freebsd.org/changeset/ports/422826
>>>
>>> Log:
>>>   - Update to 1.0.11
>>>
>>>   No bump for dependent port is required as this version has no API
>>> changes
>>>
>>>
>>> Modified: head/security/libsodium/pkg-plist
>>> ==============================================================================
>>>
>>> --- head/security/libsodium/pkg-plist    Tue Sep 27 18:25:34 2016
>>> (r422825)
>>> +++ head/security/libsodium/pkg-plist    Tue Sep 27 19:43:32 2016
>>> (r422826)
>>> @@ -58,7 +58,7 @@ include/sodium/version.h
>>>  lib/libsodium.a
>>>  lib/libsodium.so
>>>  lib/libsodium.so.18
>>> -lib/libsodium.so.18.1.0
>>> +lib/libsodium.so.18.1.1
>>>  libdata/pkgconfig/libsodium.pc
>>>  %%PORTDOCS%%%%DOCSDIR%%/AUTHORS
>>>  %%PORTDOCS%%%%DOCSDIR%%/README.markdown
>>>
>>
>> First, I don't think the "no API change" means a bump is not mandatory.
>> Secondly, the SO name of the library changed!!!  You have to bump it,
>> there's no question here.
>>
>> It's 1000x better to bump unnecessarily than to skip a bump that is
>> required.
>
> No it did not.
>
> $ readelf -d `make -V STAGEDIR`/usr/local/lib/libsodium.so|grep soname
>  0x000000000000000e SONAME               Library soname: [libsodium.so.18]
>
> The file name changed, but software will try to find libsodium.so.18,
> and that will still work.
>

regardless, why should the bump be avoided?
There could have been fixes against the existing functions.

I'm starting to see a lot of people go out of their way to bump and I 
don't know where the trend is coming from.

Is portmgr saying vsevolod is correct not to bump this?  I would bump it 
and if that's wrong maybe my bump criteria is wrong.

John

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus