svn commit: r421576 - in head/x11-wm/fluxbox: . files

[Mathieu Arnold]

Le 09/09/2016 à 06:40, Alexey Dokuchaev a écrit :
> On Thu, Sep 08, 2016 at 08:07:19PM +0000, Jason Helfman wrote:
>> New Revision: 421576
>> URL: https://svnweb.freebsd.org/changeset/ports/421576
>>
>> [...]
>> -PORTDOCS=		AUTHORS ChangeLog NEWS README TODO
>> +PORTDATA=	*
>> +PORTDOCS=	*
>> ...
>> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_active.xpm
>> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_pressed.xpm
>> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_unfocus.xpm
>> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_active.xpm
>> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_pressed.xpm
>> ...
> Please don't do this.  We should had never allowed globbed PORTDATA (it is
> less of an issue for PORTDOCS since they are usually less important and
> interesting).
>
> We have pkg-plist for a reason.  It helps to track changes, assess them
> against the changelog, compare pkg-plists of different versions, etc.
>
> Previously I could see a new theme/style files in the commit diff and
> think, "hey, I should try that new version, wanna see it that theme looks
> nicer than my current one".  Now it becomes harder.

As a side note, I plan on deprecating the PORTDATA macro soon for that
exact reason.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160909/1f944ac5/attachment.sig>