svn commit: r416053 - head/Mk/Uses
Kurt Jaeger
pi at FreeBSD.org
Sun May 29 15:44:12 UTC 2016
Hi!
> > Done. I'm not sure *why* the kde folks requested this change
> > in the first place, so I'll ask them.
>
> In this case I'm even more puzzled: why commit a change that you don't fully
> understand?
The KDE folks asked for committer support to get a bunch of changes
in the tree, because there's a backlog. So I worked on those PRs,
and I looked at that change, and it did look innocent and valid, without
investigating all it's implications.
> You should've asked them before committing, not after.
It probably comes down to weight the balance between perfection
and timeliness. A change never done is a change that was never wrong.
> Writing proper commit messages also helps: lack of "why" clause (or inability
> to come up with one) indicates that change is probably not committable yet.
I agree, that's what I try to get across to the kde folks. Still
not perfect, I know 8-}
--
pi at FreeBSD.org +49 171 3101372 4 years to go !
More information about the svn-ports-all
mailing list