svn commit: r416053 - head/Mk/Uses

Kurt Jaeger pi at FreeBSD.org
Sat May 28 20:03:01 UTC 2016


Hi!

> |  .if !target(do-configure) && ! ${qmake_ARGS:M_env}
> | -_USES_configure+=	450:qmake-configure
> | +do-configure: qmake-configure
> | +	@${DO_NADA}
> |  .endif
> 
> I should explain a bit more.
> 
> This goes against the Right Way Of Doing Things(c)(r)(tm).
> 
> To add a target to be run in the targets pipeline, you use _USES_xxx, you
> never, ever, piggyback on an existing target, especially if you're not
> using it.
> 
> So, please, back this out.

Done. I'm not sure *why* the kde folks requested this change
in the first place, so I'll ask them.

-- 
pi at FreeBSD.org         +49 171 3101372                4 years to go !


More information about the svn-ports-all mailing list