svn commit: r415493 - in head/games/libretro-cores: . files

John Marino freebsd.contact at marino.st
Tue May 24 12:50:51 UTC 2016


On 5/24/2016 2:31 PM, Mathieu Arnold wrote:
> +--On 24 mai 2016 12:05:25 +0200 John Marino <freebsd.contact at marino.st>
> wrote:
> |>  do-build:
> |>  	@for dir in ${CORE_DIRS}; do \
> |> -	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core $${dir} (`date`)"; \
> |> -	  if [ -f ${WRKSRC}/$${dir}/Makefile.freebsd ]; then \
> |> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.freebsd ${_MAKE_JOBS} ${MAKE_ARGS}); \ -	  elif [
> |> -f ${WRKSRC}/$${dir}/Makefile.libretro ]; then \
> |> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.libretro ${_MAKE_JOBS} ${MAKE_ARGS}); \ +
> |> ${ECHO_MSG} "===>  Building for ${PKGNAME}: core ${dir} ($$(date))"; \ +
> |> 	  cd ${WRKSRC}/${dir}; \
> |
> | We think this is a mistake:
> | changing "cd ${WRKSRC}/$${dir};" to "cd ${WRKSRC}/${dir};"
> | ("core $${dir}" => "core ${dir}" is wrong too but that's only an echo
> | issue)
> |
> | I'm wondering how this is working on FreeBSD actually ...
>
> Mmmm, good catch, I changed it back from a make .for to a shell one at the
> last minute and messed it up.

There's a second problem too.
You have to revert this one:

-	  ${CP} $$(find ${WRKSRC}/$${dir} -name "*.so") 
${STAGEDIR}/${PREFIX}/libexec/libretro/; \
+	  ${INSTALL_LIB} $$(find ${WRKSRC}/${dir}/ -name "*.so") 
${STAGEDIR}/${PREFIX}/libexec/libretro); \

The last ")" prevents installation from installating.  It fails for us 
outright on the during staging.

Thanks,
John





More information about the svn-ports-all mailing list