svn commit: r415434 - head/devel/fb-adb

Mathieu Arnold mat at FreeBSD.org
Wed May 18 15:19:21 UTC 2016


+--On 18 mai 2016 17:10:32 +0200 Jan Beich <jbeich at FreeBSD.org> wrote:
|>  .else
|> -NDK_DISTFILES=		${DISTNAME_ndk}.bin:ndk,p7zip
|> +NDK_DISTFILES=		${DISTNAME_ndk}.bin:ndk
|>  DISTNAME_ndk=		android-ndk-r10e-linux-${LINUX_RPM_ARCH:C/i.86/x86/}
|>  WRKSRC_ndk=		${WRKDIR}/${DISTNAME_ndk:C/(-[^-]+){2}$//}
|>  .endif
| 
| I disagree with the fix. Either put :p7zip in MASTER_SITES as well or
| use EXTRACT_ONLY{,_7z} directly. LINUX_RPM_ARCH=x86_64 distfile fails to
| extract with bsdtar(1), so :p7zip group limits USES=7z:partial,p7zip to
| the specific file. For details, see do-p7zip-extract implementation.

The p7zip MASTER_SITES group does not exist. It is going to be an error
soon.
I see now that this port, and USES=7z are abusing the fact that nonexistant
groups are just overlooked right now.
This port should better be using the EXTRACT_ONLY_7z variable for that.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160518/f8bd672c/attachment.sig>


More information about the svn-ports-all mailing list