svn commit: r408973 - head/lang/dmd2

Cy Schubert Cy.Schubert at komquats.com
Tue Feb 16 14:24:06 UTC 2016


In message <3772ed9d654255d394ee12249d1f7ee8 at gahr.ch>, Pietro Cerutti 
writes:
> On 2016-02-16 04:30, Cy Schubert wrote:
> > Author: cy
> > Date: Tue Feb 16 03:30:06 2016
> > New Revision: 408973
> > URL: https://svnweb.freebsd.org/changeset/ports/408973
> > 
> > Log:
> >   Correctly locate dmd.conf.
> 
> This is wrong. Your latest 2 commits result in effectively hardcoding 
> PREFIX to /usr/local. See the two snippets below.
> Could you please revert to having posix.mak specify SYSCONFDIR=/etc and 
> our Makefile substitute /etc with ${PREFIX}/etc?
> Or anything that is functionally equivalent.
> 
> Thanks,
> 
> 
> 
> > ===========================================================================
> ===
> > --- head/lang/dmd2/Makefile	Tue Feb 16 02:52:56 2016	(r408972)
> > +++ head/lang/dmd2/Makefile	Tue Feb 16 03:30:06 2016	(r408973)
> > @@ -65,7 +66,6 @@ post-patch:
> >  			  -e "s|\\\BR|.BR|"		\
> >  		${WRKDIR}/dmd2/man/man1/dmd.1		\
> >  		${WRKDIR}/dmd2/man/man5/dmd.conf.5
> > -	@${REINPLACE_CMD} -e '/^SYSCONFDIR=/s|/etc/|${PREFIX}/etc/|'
> 
> 
> =============================================================================
> =
> --- head/lang/dmd2/files/patch-src__dmd__posix.mak    Thu Jan 28 
> 20:44:35 2016    (r407420)
> +++ head/lang/dmd2/files/patch-src__dmd__posix.mak    Thu Jan 28 
> 20:47:32 2016    (r407421)
> @@ -1,23 +1,82 @@
> ---- ../../src/dmd/posix.mak.orig    2015-11-11 02:36:12.000000000 -0800
> -+++ ../../src/dmd/posix.mak    2015-11-15 01:40:55.280252455 -0800
> -@@ -57,13 +57,13 @@
> +--- ../../src/dmd/posix.mak.orig    2016-01-27 07:22:54.000000000 -0800
> ++++ ../../src/dmd/posix.mak    2016-01-28 12:32:14.044394178 -0800
> +@@ -19,7 +19,7 @@
> + endif
> +
> + INSTALL_DIR=../../install
> +-SYSCONFDIR=/etc
> ++SYSCONFDIR=/usr/local/etc
> 
> 
> 
> -- 
> Pietro Cerutti
> gahr at FreeBSD.org
> 

Thanks for noticing. It was accidently included when the patch was 
re-rolled for r407421. It's been removed.

Thanks again.


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com> or <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.




More information about the svn-ports-all mailing list