svn commit: r408262 - head/editors/uemacs

[Bryan Drewery]

On 2/5/2016 11:52 AM, John Marino wrote:
> On 2/5/2016 8:48 PM, Bryan Drewery wrote:
>> On 2/5/2016 10:59 AM, John Marino wrote:
>>> Author: marino
>>> Date: Fri Feb  5 18:59:49 2016
>>> New Revision: 408262
>>> URL: https://svnweb.freebsd.org/changeset/ports/408262
>>>
>>> Log:
>>>   editors/uemacs: document ncurses rqmt (USES+=ncurses), respect LDFLAGS
>>>   
>>>   Also link with ncurses, not termcap
>>>   
>>>   approved by:	infrastructure blanket
>>>
>>> Modified:
>>>   head/editors/uemacs/Makefile
>>>
>>> Modified: head/editors/uemacs/Makefile
>>> ==============================================================================
>>> --- head/editors/uemacs/Makefile	Fri Feb  5 18:57:54 2016	(r408261)
>>> +++ head/editors/uemacs/Makefile	Fri Feb  5 18:59:49 2016	(r408262)
>>> @@ -13,10 +13,12 @@ COMMENT=	Full screen editor
>>>  NO_CDROM=	Resale allowed for media cost only
>>>  
>>>  NO_WRKSUBDIR=	yes
>>> -USES=		dos2unix zip
>>> +USES=		dos2unix ncurses zip
>>>  EXTRACT_BEFORE_ARGS=	-Lq
>>>  
>>>  post-patch:
>>>  	@${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c
>>> +	@${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \
>>> +		${WRKSRC}/freebsd/makefile
>>>  
>>>  .include <bsd.port.mk>
>>>
>>
>> lrwxr-xr-x  1 root  wheel  13 Mar 27  2015 /usr/lib/libtermcap.so@ ->
>> libncurses.so
>>
>> libtermcap is symlinked to libncurses. Why is it worth maintaining extra
>> code to link to ncurses directly?
>>
> 
> Libtermcap does not exist in ports, it's not in devel/ncurses.
> If one wants doesn't want to use base, the port can't be built.  The
> obvious solution is make everythink link with libncurses so both base
> and ports options are supported.
> 
> 

Ok. The massive symlinking to ncurses in base bothers me as it creates
issues for build dependencies for me. I have considered trying to
eliminate them but haven't gone forward with it since it would break too
much.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160205/f4aae93c/attachment.sig>