svn commit: r407901 - in head/net-mgmt/collectd5: . files

[Guido Falsi]

On 02/03/16 09:52, Guido Falsi wrote:
> On 02/03/16 07:56, Alexey Dokuchaev wrote:
>> On Tue, Feb 02, 2016 at 11:08:46PM +0000, Guido Falsi wrote:
>>> New Revision: 407901
>>> URL: https://svnweb.freebsd.org/changeset/ports/407901
>>>
>>> Log:
>>>   - Update to 5.5.1
>>>   - Mark MONGODB option as BROKEN
>>
>> Commit log does not explain what's exactly broken, which makes it (the log)
>> pretty useless. :(
> 
> That information is in the PR, which is referenced by the commit
> message, I thought that could be enough.
> 
>>
>>> +1,032 	-2 	head/net-mgmt/collectd5/files/patch-src__Makefile.in
>>
>> This huge patch suggests that it's probably better to patch Makefile.am and
>> regenerate Makefile.in instead.
> 
> I must admit I'm not an expert with the autotools so I took the
> submitter's work for granted as long as it worked.
> 
> I can try to fix this by working with him and see if we can get a better
> patch.
> 

Some further analysis shows that the port is already regenerating the
.in files, most probably this patch slipped into the diff by mistake, I
should have caught this.

Sorry for the mistake, I'm making sure everything works fine without it
and will commit a fix once sure.

Thanks for reporting.

-- 
Guido Falsi <mad at madpilot.net>