svn commit: r420625 - head/security/libargon2
John Marino
marino at FreeBSD.org
Mon Aug 22 17:16:31 UTC 2016
Author: marino
Date: Mon Aug 22 17:16:30 2016
New Revision: 420625
URL: https://svnweb.freebsd.org/changeset/ports/420625
Log:
security/libargon2 is not jobs safe
This concurrent flaw is pretty awful but easily fixed.
The "all" target depends on "clean $(RUN) libs".
In a multijob invocation, these targets all start building at the
same time beccause there's no requirement to clean before building.
As a result, it's possible that some object files get built before the
clean target runs, which deletes the built files.
Probably this can be solved by simply removing the "clean" target which
should be unnecessary in a ports build area. I'll leave that to the
maintainer to either patch or notify upstream of this obvious makefile
flaw.
Modified:
head/security/libargon2/Makefile
Modified: head/security/libargon2/Makefile
==============================================================================
--- head/security/libargon2/Makefile Mon Aug 22 16:49:02 2016 (r420624)
+++ head/security/libargon2/Makefile Mon Aug 22 17:16:30 2016 (r420625)
@@ -18,6 +18,8 @@ GH_TAGNAME= 4625cc5
USES= gmake
USE_LDCONFIG= yes
+MAKE_JOBS_UNSAFE= yes
+
do-install:
${INSTALL_DATA} ${WRKSRC}/include/argon2.h ${STAGEDIR}${PREFIX}/include
${INSTALL_LIB} ${WRKSRC}/libargon2.a ${STAGEDIR}${PREFIX}/lib
More information about the svn-ports-all
mailing list