svn commit: r420435 - in head/sysutils: cfengine33 cfengine34 cfengine35 cfengine36 cfengine37 cfengine38 cfengine39

[Adam Weinberger]

> On 18 Aug, 2016, at 19:20, Cy Schubert <Cy.Schubert at komquats.com> wrote:
> 
> In message <E1569D9B-9C86-4707-ABC7-E0080DD5B59F at adamw.org>, Adam 
> Weinberger wr
> ites:
>>> On 18 Aug, 2016, at 18:37, Cy Schubert <cy at FreeBSD.org> wrote:
>>> 
>>> Author: cy
>>> Date: Fri Aug 19 00:37:47 2016
>>> New Revision: 420435
>>> URL: https://svnweb.freebsd.org/changeset/ports/420435
>>> 
>>> Log:
>>> Update @unexec with modern @postunexec.
>>> 
>>> Modified: head/sysutils/cfengine33/pkg-plist
>>> ===========================================================================
>> ===
>>> --- head/sysutils/cfengine33/pkg-plist	Thu Aug 18 23:28:59 2016
>> 	(r420434)
>>> +++ head/sysutils/cfengine33/pkg-plist	Fri Aug 19 00:37:47 2016
>> 	(r420435)
>>> 
>>> - at unexec rmdir "/var/cfengine/inputs" >/dev/null 2>&1 || :
>>> + at postunexec rmdir "/var/cfengine/inputs" >/dev/null 2>&1 || :
>> 
>> Why not just plain old
>> 	@dir /var/cfengine/inputs
>> @dir will happily ignore non-empty directories.
>> 
>> And combining with your next commit, you can just
>> 	@dir(root,wheel,700) /var/cfengine/ppkeys
> 
> Does that not delete the directory upon package deletion? If upgrading, 
> you're left with no keys, no data.
> 
> I suppose though, this could work because the directories would have data 
> and would not be deleted, except for a nasty message to the user. Either 
> way, it's a hack.

AFAIK, @dir should never remove anything except empty directories.

The only difference I'm aware of between @dir and the previous @postunexec is the >/dev/null, and the ability to set mode/ownership and declare the dir at the same time.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org