svn commit: r419993 - in head: mail/libmapi net/nanomsg

[Emmanuel Vadot]

On Wed, 10 Aug 2016 11:03:22 +0200
Mathieu Arnold <mat at FreeBSD.org> wrote:

> 
> 
> +--On 10 août 2016 18:57:42 +1000 Kubilay Kocak <koobs at FreeBSD.org> wrote:
> | On 10/08/2016 6:21 PM, Emmanuel Vadot wrote:
> |> +.if ${PORT_OPTIONS:MDOCS}
> |> +CMAKE_ARGS+=	-DCMAKE_INSTALL_MANDIR:STRING=man
> |> +.else
> |> +CMAKE_ARGS+=	-DNN_ENABLE_DOC=OFF
> |>  .endif
> | 
> | This block can/should be replaced with options helpers (placed under
> | DOCS_BUILD_DEPENDS):
> | 
> | DOCS_CMAKE_BOOL=	NN_ENABLE_DOC
> | DOCS_CMAKE_ON=		-DCMAKE_INSTALL_MANDIR:STRING=man
> | 
> | See Mk/bsd.options.mk for details.
> 
> Well, no, that should be, see the porter's handbook for details:
> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html

 I have this : https://people.freebsd.org/~manu/fix_nanomsg_doc.diff

 Everything is fine on the poudriere side (with and without DOCS option set)
 Do you guys want a new PR ?

-- 
Emmanuel Vadot <manu at bidouilliste.com>