svn commit: r419716 - in head/games: . zdoom

[Baptiste Daroussin]

On Sat, Aug 06, 2016 at 07:55:10AM +0000, Alexey Dokuchaev wrote:
> On Sat, Aug 06, 2016 at 09:38:30AM +0200, Mathieu Arnold wrote:
> > +--On 6 ao??t 2016 07:36:04 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
> > | 
> > | Why?  Now it looks inconsistent:
> > | 
> > | % make -V PLIST_FILES
> > | bin/zdoom  /usr/local/share/zdoom/zdoom.pk3
> > | 
> > | If your point was to avoid plist substitutions for some reason (if they do
> > | not work in PLIST_FILES it looks like a bug that should be fixed instead),
> > | ${DATADIR_REL} still suits better.
> > 
> > Substitutions are there for one reason only, to be able to carry variables
> > from the Makefile to the pkg-plist file.
> 
> Ah right, ignore what I said about a bug that should be fixed. :-/
> 
> > DATADIR is just fine, it is the full path to the file, which is supported.
> 
> Except that it looks inconsistent and ugly.  Mixing relative and absolute
> paths might also be error-prone.

Actually it is less error prone to have absolute path (but less consistent)
because it will avoid issues we already had a lot in the path when someone badly
uses '@cwd' without resetting it and PLIST_FILES ends up being appended after
that.

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160806/ac303a6d/attachment.sig>