svn commit: r419716 - in head/games: . zdoom

[Mathieu Arnold]

+--On 6 août 2016 07:36:04 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
wrote:
| On Sat, Aug 06, 2016 at 02:01:32AM +0200, Mathieu Arnold wrote:
|> +--On 5 ao??t 2016 23:08:37 +0000 Pawel Pekala <pawel at FreeBSD.org> wrote:
|> | +PLIST_FILES=	bin/${PORTNAME} \
|> | +		%%DATADIR%%/${PORTNAME}.pk3
|> 
|> This should be:
|> PLIST_FILES=	bin/${PORTNAME} \
|> 		${DATADIR}/${PORTNAME}.pk3
| 
| Why?  Now it looks inconsistent:
| 
| % make -V PLIST_FILES
| bin/zdoom  /usr/local/share/zdoom/zdoom.pk3
| 
| If your point was to avoid plist substitutions for some reason (if they do
| not work in PLIST_FILES it looks like a bug that should be fixed instead),
| ${DATADIR_REL} still suits better.

Substitutions are there for one reason only, to be able to carry variables
from the Makefile to the pkg-plist file.  DATADIR is just fine, it is the
full path to the file, which is supported.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160806/aa43c0bc/attachment.sig>