svn commit: r397981 - head/net-mgmt/net-snmp

[Bryan Drewery]

On 9/26/2015 7:50 AM, Bryan Drewery wrote:
> On 9/26/2015 7:21 AM, Ryan Steinmetz wrote:
>> Author: zi
>> Date: Sat Sep 26 14:21:39 2015
>> New Revision: 397981
>> URL: https://svnweb.freebsd.org/changeset/ports/397981
>>
>> Log:
>>   - Honor WITHOUT_SSP
>>   
>>   PR:		203369
>>   Submitted by:	Kenneth Salerno <kennethsalerno at yahoo.com>
>>
>> Modified:
>>   head/net-mgmt/net-snmp/Makefile
>>
>> Modified: head/net-mgmt/net-snmp/Makefile
>> ==============================================================================
>> --- head/net-mgmt/net-snmp/Makefile	Sat Sep 26 14:13:44 2015	(r397980)
>> +++ head/net-mgmt/net-snmp/Makefile	Sat Sep 26 14:21:39 2015	(r397981)
>> @@ -52,10 +52,13 @@ CONFIGURE_ARGS+=--enable-shared --enable
>>  		--with-logfile="${NET_SNMP_LOGFILE}" \
>>  		--with-persistent-directory="${NET_SNMP_PERSISTENTDIR}" \
>>  		--with-gnu-ld --with-libwrap \
>> -		--with-libs="-lssp_nonshared" \
>>  		--with-ldflags="-lm -lkvm -ldevstat -L${PKG_PREFIX}/lib -L${LOCALBASE}/lib ${LCRYPTO}"

Or just add ${LDFLAGS} in there with the other libs!

>>  SUB_FILES=	pkg-message
>>  
>> +.if !defined(WITHOUT_SSP)
>> +CONFIGURE_ARGS+=--with-libs="-lssp_nonshared"
>> +.endif
>> +
>>  .if defined(BATCH)
>>  CONFIGURE_ARGS+=--with-defaults
>>  .endif
>>
> 
> bsd.ssp.mk should be in charge of this.
> 
> I think to fix your problem you should just do:
> 
> CONFIGURE_ARGS+= --with-libs="${LDFLAGS:M-l*}"
> 
> Note that there are no SSP checks here. It simple converts any -l in
> LDFLAGS to the --with-libs format. I haven't tested this yet but wanted
> to get it out there still. Having no -l in LDFLAGS
> will pass --with-libs= with no params. If it builds fine like that then
> it is fine. Otherwise it will be more tricky due to the ordering of
> including files from Mk/.
> 
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150926/6092ee14/attachment.bin>