svn commit: r399935 - head/Mk

[Bryan Drewery]

> On Oct 22, 2015, at 07:27, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
> On Thu, Oct 22, 2015 at 07:17:44AM -0700, Bryan Drewery wrote:
>>>> On Oct 22, 2015, at 01:34, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
>>>> On Wed, Oct 21, 2015 at 09:49:46PM +0000, Bryan Drewery wrote:
>>>> New Revision: 399935
>>>> URL: https://svnweb.freebsd.org/changeset/ports/399935
>>>> 
>>>> Log:
>>>> Revert r399921 for now due to fallout with libclc using ninja.
>>>> 
>>>> [...]
>>>> -.if defined(PACKAGE_BUILDING)
>>>> -MAKE_ARGS+=            V=1
>>>> -.endif
>>> 
>>> I've expected that something like this will bite us if we go the MAKEARGS+=
>>> V=1 path [1] for obtaining verbose logs for package builds.  (I didn't know
>>> you'be been working on it; it would be nice if you'd joined that discussion
>>> back in September.)
>> 
>> I wasn't. It was just from a quick discussion on irc due to a build failure
>> where hiding the rules was problematic.
>> 
>>> You can try grepping configure script for version and --disable-silent-rules
>>> option as a safer alternative to always passing V=1 to make(1).
>> 
>> Yes that is what we will have to do.
> 
> Nice; feel free to add me on reviewer's list when you have a patch ready. :)
> 
> 

I definitely made a mistake rushing it in. Someone else mentioned potential problems too. FWIW I did schedule on unrelated exp-run before this yesterday. I really didn't expect things to have GNU_CONFIGURE and ninja!