svn commit: r399705 - head/net-mgmt/aircrack-ng

[Lars Engels]

On Tue, Oct 20, 2015 at 03:28:12PM +0200, Mathieu Arnold wrote:
> +--On 20 octobre 2015 15:14:52 +0200 Lars Engels <lars.engels at 0x20.net>
> wrote:
> | On Tue, Oct 20, 2015 at 11:26:00AM +0200, Mathieu Arnold wrote:
> |> 
> |> 
> |> +--On 19 octobre 2015 20:33:35 +0200 Jan Beich <jbeich at vfemail.net>
> |> wrote:
> |> | Lars Engels <lme at FreeBSD.org> writes:
> |> | 
> |> |> +INSTALL_TARGET=	strip install
> |> | [...]
> |> |> -post-install:
> |> |> -	@${STRIP_CMD} ${BIN_FILES:S,^,${STAGEDIR}${PREFIX}/bin/,} \
> |> |> -		${SBIN_FILES:S,^,${STAGEDIR}${PREFIX}/sbin/,}
> |> | 
> |> | This always strips the binaries, even for WITH_DEBUG=1. The magic for
> |> | INSTALL_TARGET in bsd.port.mk only works with default automake target.
> |> | 
> |> | Index: net-mgmt/aircrack-ng/Makefile
> |> | ===================================================================
> |> | --- net-mgmt/aircrack-ng/Makefile	(revision 399707)
> |> | +++ net-mgmt/aircrack-ng/Makefile	(working copy)
> |> | @@ -18,7 +18,7 @@ CPE_VERSION=	${DISTVERSION:C/-.*//}
> |> |  CPE_UPDATE=	${DISTVERSION:C/^[^-]*$//:C/.*-//}
> |> |  DOS2UNIX_FILES=	src/osdep/byteorder.h
> |> |  MAKE_ARGS=	experimental=true libnl=false prefix=${PREFIX}
> |> | -INSTALL_TARGET=	strip install
> |> | +INSTALL_TARGET=	${STRIP:S/-s/strip/} install
> |> |  USE_OPENSSL=	yes
> |> |  
> |> |  OPTIONS_DEFINE=	PCRE SQLITE
> |> 
> | 
> | Thanks Jan, I didn't think about this.
> | 
> | 
> |> This is harder to understand, if you don't know what STRIP is for, or
> |> what it contains, it does not make a lot of sense, the previous way was
> |> better, I feel.
> | 
> | I think I'll just add a comment what Jan's solution to this problem
> | does.
> | The way it was before was clumy, because I had to add [S]BIN_FILES
> | variables containing all (often changing) binaries.
> 
> You could also have run ${STRIP_CMD} ${STAGEDIR}${PREFIX}/*bin/* or
> something similar where you did not need to maintain that list :-)

No, unfortunately there are also shell scripts along "real" binaries in
those directories.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 603 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20151020/72174e48/attachment.bin>