svn commit: r398971 - in head/audio/musescore: . files

Alexey Dokuchaev danfe at FreeBSD.org
Sat Oct 10 14:44:37 UTC 2015


On Sat, Oct 10, 2015 at 09:35:15AM +0200, John Marino wrote:
> On 10/10/2015 9:08 AM, Alexey Dokuchaev wrote:
> > On Sat, Oct 10, 2015 at 05:44:35AM +0000, John Marino wrote:
> >> New Revision: 398971
> >> URL: https://svnweb.freebsd.org/changeset/ports/398971
> >>
> >> [...]
> >> +	@${REINPLACE_CMD} -e \
> >> +		's|<errno.h>|<cerrno>| ; \
> >> +		 s|<limits.h>|<climits>| ; \
> >> +		 s|<math.h>|<cmath>| ; \
> >> +		 s|<stdio.h>|<cstdio>|' ${WRKSRC}/all.h
> > 
> > I think these foo.h are missing escaping of the dot (should be foo\.h), no?
> 
> Yes, but adding a slash doesn't change the result.  It's a more correct
> matching, but the current version is good enough (e.g. <errno.h> doesn't
> match more than <errno\.h>) .  In any case, it passed a build test.

It's certainly works and is good enough, but seeing this mistake made
often I'd wanted to point it out for educational purposes given chance.

./danfe


More information about the svn-ports-all mailing list