svn commit: r402352 - head/lang/gcc

Baptiste Daroussin bapt at FreeBSD.org
Tue Nov 24 12:20:30 UTC 2015


On Tue, Nov 24, 2015 at 11:51:56AM +0000, Alexey Dokuchaev wrote:
> On Tue, Nov 24, 2015 at 12:10:22PM +0100, John Marino wrote:
> > On 11/24/2015 12:01 PM, Alexey Dokuchaev wrote:
> > > On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote:
> > >> Author: gerald
> > >> URL: https://svnweb.freebsd.org/changeset/ports/402352
> > >>
> > >> [...]
> > >> @@ -168,5 +168,10 @@ post-stage:
> > >>  	fi
> > >>  .endfor
> > >>  	cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST}
> > >> +	# This is the canonical GCC port, so add key commands without
> > >> +	# version numbers as part of their names.
> > > 
> > > Comment is badly indented (will be executed as part of the target recipe).
> > 
> > Are you sure?  I thought that only applies to legacy make, not bmake.
> 
> Hmm, indeed.
> 
> But even if bmake is smart enough to skip shell comments, it still looks
> like part of the recipe, which is not very neat.
> 
And legacy make is still used on 9.x

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20151124/f15ffa5e/attachment.bin>


More information about the svn-ports-all mailing list