svn commit: r402210 - head/sysutils/py-dlipower

[Warner Losh]

On Sat, Nov 21, 2015 at 7:27 PM, Kubilay Kocak <koobs at freebsd.org> wrote:

> On 22/11/2015 12:09 PM, Warner Losh wrote:
> > Author: imp
> > Date: Sun Nov 22 01:09:49 2015
> > New Revision: 402210
> > URL: https://svnweb.freebsd.org/changeset/ports/402210
> >
> > Log:
> >   Create dlipower, a python-based control program for Data Logger Inc's
> >   various web-based power strips.
> >
> > Added:
> >   head/sysutils/py-dlipower/
> >   head/sysutils/py-dlipower/Makefile   (contents, props changed)
> >   head/sysutils/py-dlipower/distinfo   (contents, props changed)
> >   head/sysutils/py-dlipower/pkg-descr   (contents, props changed)
> >
> > Added: head/sysutils/py-dlipower/Makefile
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/sysutils/py-dlipower/Makefile        Sun Nov 22 01:09:49 2015
>       (r402210)
> > @@ -0,0 +1,27 @@
> > +# Created by: M. Warner Losh <imp at FreeBSD.org>
> > +# $FreeBSD$
> > +
> > +PORTNAME=    dlipower
> > +PORTVERSION= 20151118
> > +CATEGORIES=  sysutils python
> > +PKGNAMEPREFIX=       ${PYTHON_PKGNAMEPREFIX}
> > +
> > +MAINTAINER=  imp at FreeBSD.org
> > +COMMENT=     CLI interface to Digital Logger's (DLI) Power Strips
> > +
> > +LICENSE=     BSD3CLAUSE
> > +LICENSE_FILE=        ${WRKSRC}/LICENSE.txt
> > +
> > +RUN_DEPENDS=
> ${PYTHON_PKGNAMEPREFIX}beautifulsoup>=4.0:${PORTSDIR}/www/py-beautifulsoup \
> > +
>  ${PYTHON_PKGNAMEPREFIX}requests>=2.0:${PORTSDIR}/www/py-requests
> > +
> > +USE_GITHUB=  yes
> > +GH_ACCOUNT=  dwighthubbard
> > +GH_PROJECT=  python-dlipower
> > +GH_TAGNAME=  9c3bb94
> > +
> > +USES=                python
> > +USE_PYTHON=  autoplist distutils
> > +NO_ARCH=     yes
> > +
> > +.include <bsd.port.mk>
> >
> > Added: head/sysutils/py-dlipower/distinfo
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/sysutils/py-dlipower/distinfo        Sun Nov 22 01:09:49 2015
>       (r402210)
> > @@ -0,0 +1,2 @@
> > +SHA256 (dwighthubbard-python-dlipower-20151118-9c3bb94_GH0.tar.gz) =
> aeeb36d5ae497f31bbfb3b09149f56c3d47889f3d00ffed879ea5d852c904ce2
> > +SIZE (dwighthubbard-python-dlipower-20151118-9c3bb94_GH0.tar.gz) = 19810
> >
> > Added: head/sysutils/py-dlipower/pkg-descr
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/sysutils/py-dlipower/pkg-descr       Sun Nov 22 01:09:49 2015
>       (r402210)
> > @@ -0,0 +1,10 @@
> > +This is a python module and a script to mange the Digital Loggers Web
> > +Power switch.
> > +
> > +The module provides a python class named PowerSwitch that allows
> > +managing the web power switch from python programs.
> > +
> > +When run as a script this acts as a command line utility to manage the
> > +DLI Power switch.
> > +
> > +WWW: https://github.com/dwighthubbard/python-dlipower
> >
>
> Since this exists in PyPI [1], references a version 0.7.117 (March
> 2015), it's probably worth asking the author for a new release.
>
> <datestamp> doesn't appear to match the version format mentioned/used
> elsewhere.
>

Maybe I'll just use the version from march. The changes since then aren't
all that important for 2.7...

Is there any issue with just switching to this version?


> I'd also ask for proper upstream (github) repository 'tags' for each
> version, at a minimum for current versions and going forward, so those
> can be used instead of having to make versions up.
>
> [1] https://pypi.python.org/pypi/dlipower
>

I can try. But the 0.7.117 version is fine.

>Is also missing 'six' as a dependency, as per setup.py:install_requires:
>
>https://github.com/dwighthubbard/python-dlipower/blob/master/setup.py#L90

I wonder why i didn't fail for me. I'll add it.

>Could probably do with USE_PYTHON=concurrent as well, to support
>multiple python versions with correctly version suffixed console scripts
[1]
>
>[1]
>https://github.com/dwighthubbard/python-dlipower/blob/master/setup.py#L104

I'm not familiar with that. How important is that?