svn commit: r401746 - in head/sysutils/pftop: . files

[Marcelo Araujo]

2015-11-16 10:55 GMT+08:00 Jason Unovitch <junovitch at freebsd.org>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On Mon, Nov 16, 2015 at 02:24:57AM +0000, Marcelo Araujo wrote:
> > Author: araujo
> > Date: Mon Nov 16 02:24:57 2015
> > New Revision: 401746
> > URL: https://svnweb.freebsd.org/changeset/ports/401746
> >
> > Log:
> >   - Add support for ALTQ FairQ and Codel protocols.
> >   - Bump PORTREVISION to 5.
> >
> >   PR:         ports/204405
> >   Submitted by:       Renato Botelho <garga at FreeBSD.org>
> >   Obtained from:      pfSense
> >   Sponsored by:       Rubicon Communications (Netgate)
> <snip>
> >  post-patch:
> > +.if ${OSVERSION} >= 1100000
> > +     @${ECHO_MSG} "===> Applying FairQ/Codel patches to ${PORTNAME}."
> > +     @${CAT} ${FILESDIR}/extra-patch-fairq_codel.diff | \
> > +             ${PATCH} ${PATCH_ARGS}
> > +.endif
> >       @${REINPLACE_CMD} -e 's|<sys/queue.h>|"${FILESDIR}/queue.h"|g' \
> >           ${WRKSRC}/engine.c
>
> Is 1100000 wise in this comparision?  According to the PHB [1], 1100080
> (r288943) looks to be the minimum safe version as CoDel landed in
> r287009 and FairQ landed in r284777.
>
> [1]
> https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/versions.html#freebsd-versions-table
>


Yes, make sense! Seems not safe use 11000000, but I will wait garga@ reply
as he submitted the patch.
In my point of view, 1100080 or above is the safest one.

Best,
-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)