svn commit: r400699 - in head/net: p5-ldap2pf p5-ldap2pw p5-srv2pf

[Alexey Dokuchaev]

On Tue, Nov 03, 2015 at 06:58:41PM +0100, Dag-Erling Sm??rgrav wrote:
> Alexey Dokuchaev <danfe at FreeBSD.org> writes:
> > I think here and below you wanted to say := instead of =.
> 
> Nope.

Indeed, I stand corrected (by myself); sorry for the false alarm.

> > Also, some of the style bugs I've mentioned earlier are still unfixed?
> 
> If you mean the unnecessary MASTER_SITES, I don't intend to fix it
> unless you also plan to fix all the other ports that do it the same way.

I think those other ports will be eventually fixed; there's certainly no
need to do it forcibly since the new GitHub handling code is doing the
right thing anyways, so explicit MASTER_SITES do not hurt anything I guess.
I wouldn't have mentioned it unless you've touched those Makefiles again.

> There are two possible values for MASTER_SITES when using Github: GH and
> GHC.  The one I use happens to be the default, but that does not IMHO go
> without saying.  I prefer to make it explicit.

I was under impression that this GH vs. GHC distinction is obsolete now,
but I'm not an expert here.

> If you mean the Oxford comma in pkg-descr: the Oxford comma is
> encouraged by some style guides and discouraged by others.  [...]

Fair enough, sorry to have caused you the extra typing.  I'll shut up
and go back to my cave now.

./danfe