svn commit: r387637 - in head/devel/tcllib: . files

[Bryan Drewery]

On 5/27/2015 12:19 PM, Mikhail Teterin wrote:
> Author: mi
> Date: Wed May 27 17:19:32 2015
> New Revision: 387637
> URL: https://svnweb.freebsd.org/changeset/ports/387637
> 
> Log:
>   Rely on critcl port to provide compiled implementations of the
>   modules, where available.
>   
>   PR:		195863
>   Approved by:	maintainer (blanket)
> 
> Added:
>   head/devel/tcllib/files/patch-jpeg   (contents, props changed)
>   head/devel/tcllib/files/patch-json   (contents, props changed)
>   head/devel/tcllib/files/patch-tests   (contents, props changed)
> Modified:
>   head/devel/tcllib/Makefile
>   head/devel/tcllib/pkg-plist
> 
> Modified: head/devel/tcllib/Makefile
> ==============================================================================
> --- head/devel/tcllib/Makefile	Wed May 27 16:26:13 2015	(r387636)
> +++ head/devel/tcllib/Makefile	Wed May 27 17:19:32 2015	(r387637)
> @@ -3,6 +3,7 @@
>  
>  PORTNAME=	tcllib
>  PORTVERSION=	1.17
> +PORTREVISION=	1
>  CATEGORIES=	devel tcl
>  
>  MAINTAINER=	tcltk at FreeBSD.org
> @@ -13,6 +14,8 @@ LICENSE_NAME=	Tcl/Tk License
>  LICENSE_FILE=	${WRKSRC}/license.terms
>  LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
>  
> +BUILD_DEPENDS=	critcl:${PORTSDIR}/devel/critcl

...

>  do-install:
>  	cd ${WRKSRC} && ${TCLSH} ./installer.tcl ${INSTALL_ARGS}
> +	${RM} ${WRKSRC}/modules/tcllibc/license.terms
> +	${CP} -Rp ${WRKSRC}/modules/tcllibc ${STAGEDIR}${PREFIX}/lib/tcllib/

...

> +lib/tcllib/tcllibc/%%BINARCH%%/tcllibc.so

Bundling libraries is bad.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/bundled-libs.html

It will also confuse pkg unless BUNDLE_LIBS=yes is added.

Can tcllib not use critcl from its own package?


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150527/874601fd/attachment.sig>