svn commit: r378563 - in head/www/chromium: . files

Jan Beich jbeich at FreeBSD.org
Fri Feb 6 23:37:43 UTC 2015


Rene Ladan <rene at FreeBSD.org> writes:

>  +#elif V8_OS_FREEBSD
> ++#  ifdef __DragonFly__
> ++  return static_cast<int>(lwp_gettid());

Ironically, V8_OS_DRAGONFLYBSD is ignored with USES=alias. Try the
following to make upstreaming easier

  #elif V8_OS_DRAGONFLYBSD || defined(__DragonFly__)
    return static_cast<int>(lwp_gettid());
  #elif V8_OS_FREEBSD
  ...

> ++#  elif __FreeBSD_version__ < 900031

Have you made sure __FreeBSD_version__ is defined?

> ++  return 0; /* ! */

Maybe replace with

    #include <sys/thr.h>
    ...
    long lwpid;
    thr_self(&lwpid);
    return static_cast<int>(lwpid);

> ++#  else

Bonus for upstream

  #if defined(OS_NETBSD)
  #include <lwp.h>
  #endif
  ...
  #elif V8_OS_NETBSD
    return static_cast<int>(_lwp_self());
  #else

>  +  return static_cast<int>(pthread_getthreadid_np());
> ++#  endif
>   #else
>     return static_cast<int>(pthread_self());
>   #endif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150207/65903ee9/attachment.sig>


More information about the svn-ports-all mailing list