svn commit: r378229 - head/sysutils/xen-tools

[Baptiste Daroussin]

On Sun, Feb 01, 2015 at 12:58:59PM +0100, Juergen Lock wrote:
> On Sun, Feb 01, 2015 at 07:33:53AM +0000, Alexey Dokuchaev wrote:
> > On Sun, Feb 01, 2015 at 07:04:36AM +0000, Dirk Meyer wrote:
> > > New Revision: 378229
> > > URL: https://svnweb.freebsd.org/changeset/ports/378229
> > > QAT: https://qat.redports.org/buildarchive/r378229/
> > > 
> > > Log:
> > >   - use full path in DEPENDS
> > 
> 
> > Modified: head/sysutils/xen-tools/Makefile
> > ==============================================================================
> > --- head/sysutils/xen-tools/Makefile	Sat Jan 31 23:32:50 2015	(r378228)
> > +++ head/sysutils/xen-tools/Makefile	Sun Feb  1 07:04:36 2015	(r378229)
> > @@ -13,9 +13,9 @@ COMMENT=	Xen tools within FreeBSD domU
> >  MASTER_SITES=	http://bits.xensource.com/oss-xen/release/${PORTVERSION}/
> >  DISTFILES=	xen-${PORTVERSION}.tar.gz
> >  
> > -BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash \
> > -		lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > -		lib/ibyajl.so:${PORTSDIR}/devel/yajl
> > +BUILD_DEPENDS=	${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> > +		${LOCALBASE}/lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > +		${LOCALBASE}/lib/ibyajl.so:${PORTSDIR}/devel/yajl
> >  
> >  USES=		gmake python:configure perl5 gettext-runtime:build gettext-tools:build pkgconfig
> >  USE_PERL5=	build
> 
> 
> > But why?  What's the reason behind this change?
> > 
> > ./danfe
> > 
> I guess he meant...
> 
> > -BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash \
> > -		lib/libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > -		lib/ibyajl.so:${PORTSDIR}/devel/yajl
> > +BUILD_DEPENDS=	bash:${PORTSDIR}/shells/bash
> > +LIB_DEPENDS=		libglib-2.0.so:${PORTSDIR}/devel/glib20 \
> > +		ibyajl.so:${PORTSDIR}/devel/yajl
> 
>  Cheers,
> 	Juergen
> 

Which would be wrong as well because xen-tools startically uses those
dependencies.

So it does not depend on any.so it depends on a .a, meaning the right fix here
would be to use BUILD_DEPENDS= ${LOCALBASE}/libglib-2.0.a and not the .so

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150202/0d531581/attachment.sig>