svn commit: r383191 - head/Mk

[Bryan Drewery]

On 4/9/2015 11:24 AM, Alexey Dokuchaev wrote:
> On Thu, Apr 09, 2015 at 11:13:34AM -0500, Bryan Drewery wrote:
>> On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote:
>>> On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote:
>>>> Read the commit log again for r369644. Setting one var and not the other
>>>> leads to incorrect behavior in many ports. You must have them matching.
>>>> It is not just about jails/chroots.
>>>
>>> I've (re)read it and understand what you're trying to accomplish; my point
>>> here is not to *build* things against custom OSVERSION, but just check if
>>> some variables are set correctly, e.g. "make -V FOO OSVERSION=xxx" is what
>>> I miss.  Is there a way to allow it again somehow?
>>
>> I understand what you're trying to do and I agree it would be useful if
>> it worked. Validating port logic (such as whether EXTRA_PATCHES has
>> something) based on OSVERSION is very useful. I'll think about how to
>> fix it.
> 
> Right, EXTRA_PATCHES is a very good example.  Good to know that there is
> mutual understanding now and a chance for a fix. :)  Thanks,
> 
> ./danfe
> 

Fixed in r384060.

You can now specify it on the cmdline. make -V BLAH OSVERSION=blah. If
it is in env or make.conf it will still error.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150415/aaf9535b/attachment.sig>