svn commit: r383184 - in head/devel/libc++: . files

[Bryan Drewery]

On 4/7/2015 12:13 PM, John Marino wrote:
> On 4/7/2015 18:57, Bryan Drewery wrote:
>> On 4/3/2015 7:22 PM, John Marino wrote:
>>> Author: marino
>>> Date: Sat Apr  4 00:22:57 2015
>>> New Revision: 383184
>>> URL: https://svnweb.freebsd.org/changeset/ports/383184
>>>
>>> Log:
>>>   devel/libc++: Mainly fix DragonFly support.
>>>   
>>>   This port was originally fixed in dports using alias:10 but this fix
>>>   was faulty.  The libc++ headers reference __FreeBSD__ so alias won't
>>>   work.  It needs to be patched to check __DragonFly__, including a file
>>>   that was the subject of EXTRA_PATCHES.
>>
>> Can you please upstream the DragonFly support?
>>
>> I am working on getting dim's patch into the port to update it and
>> conflicting with all of this.
> 
> Had I create the patch a week later, then I would have had to rework my
> patch.  Sometimes this happen.

Dim's PR is from January. PR 196536.

> 
> 
>> I think it will be simpler to use CPPFLAGS+=-D__FreeBSD__ to cover most
>> of these cases without patches.
> 
> Well, it didn't.

Setting __FreeBSD__ and __FreeBSD_version to 901501 would be the same
effect.

Though there is a bug from r353085 that incorrectly uses
_FreeBSD_version rather than __FreeBSD_version that would need to be
fixed for that to work.

r353085 | bapt | 2014-05-06 07:20:43 -0500 (Tue, 06 May 2014) | 2 lines
Fix build on FreeBSD 9.1

>>>   Moreover, the port was installing the .orig files left over from
>>>   patching.  I remove these in post-patch now.
>>
>> I don't think this is a problem worth fixing. check-plist already
>> ignores .orig files.
> 
> Well, it's fixed now so the fix isn't work removing.
> 

The staging/check-plist work resulted in not needing to check options or
remove various files from the stagedir. Removing stuff like that is
under the cleanup blanket. Generally NOPS in port files are just removed.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150407/b0d9bcdb/attachment.sig>