svn commit: r383112 - head/databases/postgresql94-server

Sunpoet Po-Chuan Hsieh sunpoet at freebsd.org
Fri Apr 3 15:25:52 UTC 2015


On Fri, Apr 3, 2015 at 11:17 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:

> On Fri, Apr 03, 2015 at 11:08:47PM +0800, Sunpoet Po-Chuan Hsieh wrote:
> > Regarding the CPE PRs, though Shun submitted the patch as
> "USES+=<tab>cpe",
> > I would be grateful if you could use more tabs to have same indent with
> > other lines. It needs 2 tabs in this case.
>
> +1000.  I was hoping someone would finally speak up on this matter (so I
> won't be blamed for nitpicking this time ;-)
>
> Also, in addition to bogus indentation, I don't see any need to use += vs.
> just = .
>
> ./danfe
>

I forgot I mentioned that this commit is unnecessary in the followup of
r381722.
Though duplicate items in USES are harmless, we only need to add USES+=cpe
for postgresql{84,91,92}-server/Makefile.

% tail -1 postgresql*-server/Makefile
==> postgresql84-server/Makefile <==
.include <bsd.port.post.mk>

==> postgresql90-server/Makefile <==
.include "${.CURDIR}/../postgresql91-server/Makefile"

==> postgresql91-server/Makefile <==
.include <bsd.port.post.mk>

==> postgresql92-server/Makefile <==
.include <bsd.port.post.mk>

==> postgresql93-server/Makefile <==
.include "${.CURDIR}/../postgresql92-server/Makefile"

==> postgresql94-server/Makefile <==
.include "${.CURDIR}/../postgresql92-server/Makefile"

% grep cpe postgresql*-server/Makefile
postgresql90-server/Makefile:USES+=     cpe
postgresql91-server/Makefile:USES+=     cpe
postgresql92-server/Makefile:USES+=     cpe
postgresql93-server/Makefile:USES+=     cpe
postgresql94-server/Makefile:USES+=     cpe

Regards,
sunpoet


More information about the svn-ports-all mailing list