svn commit: r372261 - in head/devel/ding-libs: . files

Ryan Steinmetz zi at FreeBSD.org
Fri Nov 7 15:26:51 UTC 2014


On (11/07/14 16:19), John Marino wrote:
>On 11/7/2014 16:12, Ryan Steinmetz wrote:
>> On (11/07/14 14:54), John Marino wrote:
>>> On 11/7/2014 14:33, Ryan Steinmetz wrote:
>>>> +LIBS+=        -L${LOCALBASE}/lib -liconv -lintl
>>>
>>> shouldn't that be:
>>> LIBS+=        -L${LOCALBASE}/lib ${ICONVLIB} -lintl
>>>
>>> or something like that?
>>
>> Not unless you can tell me what defines ICONVLIB. :)
>>
>
>Mk/Uses/iconv.mk
>
>setting it unconditionally is normally wrong.  iconv.mk defines it when
>it's needed.
>

Ah, I was grepping for ICONVLIB, not ICONV_LIB.  Will pass this onto the
maintainer for testing.

-r


>John

-- 
Ryan Steinmetz
PGP: 9079 51A3 34EF 0CD4 F228  EDC6 1EF8 BA6B D028 46D7


More information about the svn-ports-all mailing list