svn commit: r355806 - head/x11-themes/clearlooks-themes-extras

[John Marino]

On 5/30/2014 11:31, Antoine Brodin wrote:
> On Fri, May 30, 2014 at 11:23 AM, John Marino <marino at freebsd.org> wrote:
>> Author: marino
>> Date: Fri May 30 09:23:02 2014
>> New Revision: 355806
>> URL: http://svnweb.freebsd.org/changeset/ports/355806
>> QAT: https://qat.redports.org/buildarchive/r355806/
>>
>> Log:
>>   x11-themes/clearlooks-themes-extras: Stage support+
>>
>>   In addition to supporting stage, the unnecessarily custom extraction
>>   target was replaced with NO_WRKSUBDIR.
>>
>> Modified:
>>   head/x11-themes/clearlooks-themes-extras/Makefile
> 
> Hi,
> 
> This looks wrong:
> - creates a directory outside of stagedir during install

I missed "@${MKDIR} ${THEME_DIR}" => "@${MKDIR} ${STAGEDIR}${THEME_DIR}"
unfortunately redports didn't complain


> - use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull

why?  I would have used COPYTREE or something myself but I don't see
anything immediately wrong with this.

John