svn commit: r353466 - head/astro/cfitsio

[Tijl Coosemans]

On Sat, 10 May 2014 03:38:03 +0800 Sunpoet Po-Chuan Hsieh wrote:
> On Sat, May 10, 2014 at 12:11 AM, Tijl Coosemans <tijl at freebsd.org> wrote:
>> On Fri, 9 May 2014 15:26:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote:
>>> Author: sunpoet
>>> Date: Fri May  9 15:26:05 2014
>>> New Revision: 353466
>>> URL: http://svnweb.freebsd.org/changeset/ports/353466
>>> QAT: https://qat.redports.org/buildarchive/r353466/
>>>
>>> Log:
>>>   - Pass -lz to libdata/pkgconfig/cfitsio.pc
>>>   - Bump PORTREVISION for package change
>>>
>>>   PR:         ports/189487
>>>   Submitted by:       rakuco
>>
>> Can you patch cfitsio.pc to move @LIBS@ to the Libs.private field?
>> Other ports run 'pkg-config --libs cfitsio' to know what libraries
>> to link to and the output of that includes -lz now.
>> "-L${LIBDIR}" can be removed I think.  All compilers should search
>> it by default.
> 
> I prepared a new patch [1] which reverted r353466 and patched cfitsio.pc.
> It's OK in my tinderbox.
> Would you please check if it works for you?
> Thanks!
> 
> [1] https://people.freebsd.org/~sunpoet/cfitsio.patch

I think this may reintroduce the problem that Raphael reported.  The
problem is a line in Makefile.in that says "LDFLAGS=$(CFLAGS)".
If you add this to post-patch it'll be ok I think:

@${REINPLACE_CMD} -e '/^LDFLAGS =/ s|$$| @LDFLAGS@|' ${WRKSRC}/Makefile.in

To fix the PR the output of "ldd libcfitsio.so" must contain libz.