svn commit: r353008 - in head/security: clamav clamav-devel clamav-devel/files clamav/files

[Mark Felder]

On 2014-05-06 04:31, Matthew D. Fuller wrote:
> On Mon, May 05, 2014 at 02:38:17PM +0000 I heard the voice of
> Mark Felder, and lo! it spake thus:
>> Author: feld
>> Date: Mon May  5 14:38:17 2014
>> New Revision: 353008
>> URL: http://svnweb.freebsd.org/changeset/ports/353008
>> QAT: https://qat.redports.org/buildarchive/r353008/
>> 
>> Log:
>>   rc script spring cleaning -- now passes rclint
> 
> I think you accidentally swept the stove outside   :)
> 
>> Modified: head/security/clamav-devel/files/clamav-milter.in
>> ==============================================================================
> [...]
>> +: ${clamav_milter_flags="-c ${conf_file}"}
> [...]
>>  conf_file=%%PREFIX%%/etc/clamav-milter.conf
> [...]
>> -: ${clamav_milter_flags="-c ${conf_file}"}
> 
> This is now winding up with ${conf_file} being used before defined,
> making the startup process drop a hairball at my feet...

Nice catch. Neither Garga nor myself have ever used clamav-milter and 
didn't have a test environment to catch what our eyes did not... 
definitely threw the baby out with the bath water there.

Thanks for the heads up!