svn commit: r347964 - in head: . Mk Mk/Uses

Baptiste Daroussin bapt at FreeBSD.org
Thu Mar 13 00:32:08 UTC 2014


On Wed, Mar 12, 2014 at 11:58:20PM +0100, Gerald Pfeifer wrote:
> On Wed, 12 Mar 2014, Baptiste Daroussin wrote:
> > Added: head/Mk/Uses/lha.mk
> > ==============================================================================
> > +# $FreeBSD$
> > +#
> > +# handle lha archives
> 
> Looking at new committers and casual contributors who join in the future, 
> this feels a bit brief.  What do you think about making this something 
> like
> 
>   Use this when a port's sources are in the lha archive format.
> 
> ?  Are you approve me making this change?
> 
> > Added: head/Mk/Uses/tar.mk
> > ==============================================================================
> > +# handle tar archives
> > +#
> > +# MAINTAINER: portmgr at FreeBSD.org
> > +#
> > +# Feature:	tar
> > +# Usage:	USES=tar[:[xz|Z|bzip2|tgz]]
> 
> For this cases, and others, what do you think of moving the
> MAINTAINER information towards the end of the comment block?
> 
> I like my portmgrs ;-), but the actual information about what 
> this file does feels more important.
> 
> Do you approve me making this change across Mk/Uses/* per the patch
> below?
> 
sure approved

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140313/057f15f9/attachment.sig>


More information about the svn-ports-all mailing list