svn commit: r341790 - head/multimedia/szap-s2

Juergen Lock nox at jelal.kn-bremen.de
Thu Jan 30 19:39:58 UTC 2014


On Wed, Jan 29, 2014 at 11:48:43PM +0100, Mathieu Arnold wrote:
> +--On 29 janvier 2014 22:44:37 +0000 Juergen Lock <nox at FreeBSD.org> wrote:
> | +
> | +.include <bsd.port.options.mk>
> |  
> |  do-install:
> |  	(cd ${WRKSRC} && ${INSTALL_PROGRAM} szap-s2 ${STAGEDIR}/${PREFIX}/bin)
> | -.if !defined(NOPORTDOCS)
> | -	${MKDIR} ${DOCSDIR}
> | -	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR})
> | +.if ${PORT_OPTIONS:MDOCS}
> | +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> | +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> |  .endif
> 
> Hi,
> 
> Could you remove the include of port.options and always install the DOCS
> into the staging area ? It would save us parsing bsd.port.mk one time too
> many.
> 
> Like it says on https://wiki.freebsd.org/ports/StageDir
> 
> The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases
> when installed files are big enough to cause significant I/O overhead.
> 
Indeed, I should have remembered this...  Fixed.

 Thanx! :)
	Juergen


More information about the svn-ports-all mailing list